chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h ('k') | chrome/browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

index 3963d871a73b35f6ff9b8753ee57abdce33007fd..e2cf34e47b606404ee9a8d4516edfd6772d4e276 100644

--- a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

@@ -44,15 +44,15 @@ class FullscreenObserver : public WebContentsObserver {

return WebContentsObserver::web_contents();

}

- virtual void DidShowFullscreenWidget(int routing_id) override {

+ void DidShowFullscreenWidget(int routing_id) override {

[controller_ toggleFullscreenWidget:YES];

}

- virtual void DidDestroyFullscreenWidget(int routing_id) override {

+ void DidDestroyFullscreenWidget(int routing_id) override {

[controller_ toggleFullscreenWidget:NO];

}

- virtual void DidToggleFullscreenModeForTab(bool entered_fullscreen) override {

+ void DidToggleFullscreenModeForTab(bool entered_fullscreen) override {

[controller_ toggleFullscreenWidget:YES];

}