chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/signin/inline_login_ui.h ('k') | chrome/browser/ui/webui/signin/login_ui_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

index ab41e2c6c31670a7abb925d2a751b6ccbe4af4ce..116475df4422d48373b510c1758e208f0b36c0ea 100644

--- a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

@@ -189,7 +189,7 @@ class InlineLoginUISafeIframeBrowserTest : public InProcessBrowserTest {

InProcessBrowserTest::SetUp();

}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

const GURL& base_url = embedded_test_server()->base_url();

command_line->AppendSwitchASCII(::switches::kGaiaUrl, base_url.spec());

command_line->AppendSwitchASCII(::switches::kLsoUrl, base_url.spec());

@@ -197,7 +197,7 @@ class InlineLoginUISafeIframeBrowserTest : public InProcessBrowserTest {

base_url.spec());

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

embedded_test_server()->RestartThreadAndListen();

content::WebUIControllerFactory::UnregisterFactoryForTesting(

@@ -208,7 +208,7 @@ class InlineLoginUISafeIframeBrowserTest : public InProcessBrowserTest {

GURL(kFooWebUIURL).host(), &foo_provider_);

}

- virtual void TearDownOnMainThread() override {

+ void TearDownOnMainThread() override {

test_factory_->RemoveFactoryOverride(GURL(kFooWebUIURL).host());

content::WebUIControllerFactory::UnregisterFactoryForTesting(

test_factory_.get());