chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h ('k') | chrome/browser/ui/cocoa/keystone_infobar_delegate.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h

diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h

index 42e2a62c123843f3ee45d6a789a19f43a3bc2e19..459dff4ea6aecfa62c6d58b57fdb1518d9e9d278 100644

--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h

+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h

@@ -25,12 +25,12 @@ class JavaScriptAppModalDialogCocoa : public NativeAppModalDialog {

virtual ~JavaScriptAppModalDialogCocoa();

// Overridden from NativeAppModalDialog:

- virtual int GetAppModalDialogButtons() const override;

- virtual void ShowAppModalDialog() override;

- virtual void ActivateAppModalDialog() override;

- virtual void CloseAppModalDialog() override;

- virtual void AcceptAppModalDialog() override;

- virtual void CancelAppModalDialog() override;

+ int GetAppModalDialogButtons() const override;

+ void ShowAppModalDialog() override;

+ void ActivateAppModalDialog() override;

+ void CloseAppModalDialog() override;

+ void AcceptAppModalDialog() override;

+ void CancelAppModalDialog() override;

JavaScriptAppModalDialog* dialog() const { return dialog_.get(); }