chrome/browser/ui/global_error/global_error.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/fullscreen/fullscreen_within_tab_helper.h ('k') | chrome/browser/ui/global_error/global_error_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/global_error/global_error.h

diff --git a/chrome/browser/ui/global_error/global_error.h b/chrome/browser/ui/global_error/global_error.h

index bed55ec373b0e3919e83322889570bef730bdd1d..d1f2fddf69c6b76f0cd3b7620b11434cd85eaadd 100644

--- a/chrome/browser/ui/global_error/global_error.h

+++ b/chrome/browser/ui/global_error/global_error.h

@@ -64,7 +64,7 @@ class GlobalErrorWithStandardBubble

public base::SupportsWeakPtr<GlobalErrorWithStandardBubble> {

public:

GlobalErrorWithStandardBubble();

- virtual ~GlobalErrorWithStandardBubble();

+ ~GlobalErrorWithStandardBubble() override;

// Returns an icon to use for the bubble view.

virtual gfx::Image GetBubbleViewIcon();

@@ -98,10 +98,10 @@ class GlobalErrorWithStandardBubble

virtual bool ShouldCloseOnDeactivate() const;

// GlobalError overrides:

- virtual bool HasBubbleView() override;

- virtual bool HasShownBubbleView() override;

- virtual void ShowBubbleView(Browser* browser) override;

- virtual GlobalErrorBubbleViewBase* GetBubbleView() override;

+ bool HasBubbleView() override;

+ bool HasShownBubbleView() override;

+ void ShowBubbleView(Browser* browser) override;

+ GlobalErrorBubbleViewBase* GetBubbleView() override;

private:

bool has_shown_bubble_view_;