chrome/browser/ui/webui/options/core_options_handler.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/options/cookies_view_handler.h ('k') | chrome/browser/ui/webui/options/create_profile_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/core_options_handler.h

diff --git a/chrome/browser/ui/webui/options/core_options_handler.h b/chrome/browser/ui/webui/options/core_options_handler.h

index 7512397d241d5f239a2a171d42730357dc3d5c5f..e5e5bc2593588ab92707a0b4f7c2e84deca0ca26 100644

--- a/chrome/browser/ui/webui/options/core_options_handler.h

+++ b/chrome/browser/ui/webui/options/core_options_handler.h

@@ -22,17 +22,16 @@ namespace options {

class CoreOptionsHandler : public OptionsPageUIHandler {

public:

CoreOptionsHandler();

- virtual ~CoreOptionsHandler();

+ ~CoreOptionsHandler() override;

// OptionsPageUIHandler implementation.

- virtual void GetLocalizedValues(

- base::DictionaryValue* localized_strings) override;

- virtual void InitializeHandler() override;

- virtual void InitializePage() override;

- virtual void Uninitialize() override;

+ void GetLocalizedValues(base::DictionaryValue* localized_strings) override;

+ void InitializeHandler() override;

+ void InitializePage() override;

+ void Uninitialize() override;

// WebUIMessageHandler implementation.

- virtual void RegisterMessages() override;

+ void RegisterMessages() override;

void set_handlers_host(OptionsPageUIHandlerHost* handlers_host) {

handlers_host_ = handlers_host;