chrome/browser/ui/sad_tab_helper.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sad_tab_helper.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc ('k') | chrome/browser/ui/screen_capture_notification_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sad_tab_helper.h

diff --git a/chrome/browser/ui/sad_tab_helper.h b/chrome/browser/ui/sad_tab_helper.h

index db4c032be80eba349733af897c4eca07e656517b..6e175b6058efdb256db31242228714d5f1fdcb8a 100644

--- a/chrome/browser/ui/sad_tab_helper.h

+++ b/chrome/browser/ui/sad_tab_helper.h

@@ -19,7 +19,7 @@ class SadTab;

class SadTabHelper : public content::WebContentsObserver,

public content::WebContentsUserData<SadTabHelper> {

public:

- virtual ~SadTabHelper();

+ ~SadTabHelper() override;

chrome::SadTab* sad_tab() { return sad_tab_.get(); }

@@ -31,8 +31,8 @@ class SadTabHelper : public content::WebContentsObserver,

void InstallSadTab(base::TerminationStatus status);

// Overridden from content::WebContentsObserver:

- virtual void RenderViewReady() override;

- virtual void RenderProcessGone(base::TerminationStatus status) override;

+ void RenderViewReady() override;

+ void RenderProcessGone(base::TerminationStatus status) override;

scoped_ptr<chrome::SadTab> sad_tab_;