Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: chrome/browser/ui/tab_contents/core_tab_helper.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/core_tab_helper.h
diff --git a/chrome/browser/ui/tab_contents/core_tab_helper.h b/chrome/browser/ui/tab_contents/core_tab_helper.h
index b71a56d77b68a53c29b95b8bf415ea0f02a0e255..45694ca3433e0cafe73186ad02194771f8cc9508 100644
--- a/chrome/browser/ui/tab_contents/core_tab_helper.h
+++ b/chrome/browser/ui/tab_contents/core_tab_helper.h
@@ -15,7 +15,7 @@ class CoreTabHelperDelegate;
class CoreTabHelper : public content::WebContentsObserver,
public content::WebContentsUserData<CoreTabHelper> {
public:
- virtual ~CoreTabHelper();
+ ~CoreTabHelper() override;
// Initial title assigned to NavigationEntries from Navigate.
static base::string16 GetDefaultTitle();
@@ -56,15 +56,13 @@ class CoreTabHelper : public content::WebContentsObserver,
friend class content::WebContentsUserData<CoreTabHelper>;
// content::WebContentsObserver overrides:
- virtual void DidStartLoading(
- content::RenderViewHost* render_view_host) override;
- virtual void WasShown() override;
- virtual void WebContentsDestroyed() override;
- virtual void BeforeUnloadFired(const base::TimeTicks& proceed_time) override;
- virtual void BeforeUnloadDialogCancelled() override;
- virtual bool OnMessageReceived(
- const IPC::Message& message,
- content::RenderFrameHost* render_frame_host) override;
+ void DidStartLoading(content::RenderViewHost* render_view_host) override;
+ void WasShown() override;
+ void WebContentsDestroyed() override;
+ void BeforeUnloadFired(const base::TimeTicks& proceed_time) override;
+ void BeforeUnloadDialogCancelled() override;
+ bool OnMessageReceived(const IPC::Message& message,
+ content::RenderFrameHost* render_frame_host) override;
void OnRequestThumbnailForContextNodeACK(const SkBitmap& bitmap,
const gfx::Size& original_size);

Powered by Google App Engine
This is Rietveld 408576698