chrome/browser/ui/webui/ntp/app_launcher_handler.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc ('k') | chrome/browser/ui/webui/ntp/app_resource_cache_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/app_launcher_handler.h

diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.h b/chrome/browser/ui/webui/ntp/app_launcher_handler.h

index 8fdc3b3641ed9cca6bbc21e2c8cb57b677bbfe52..617389f0c8f5a40b8be76605d70a49d645ca503a 100644

--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.h

+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.h

@@ -39,7 +39,7 @@ class AppLauncherHandler

public content::NotificationObserver {

public:

explicit AppLauncherHandler(ExtensionService* extension_service);

- virtual ~AppLauncherHandler();

+ ~AppLauncherHandler() override;

// Populate a dictionary with the information from an extension.

static void CreateAppInfo(

@@ -48,12 +48,12 @@ class AppLauncherHandler

base::DictionaryValue* value);

// WebUIMessageHandler implementation.

- virtual void RegisterMessages() override;

+ void RegisterMessages() override;

// content::NotificationObserver

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// Populate the given dictionary with all installed app info.

void FillAppDictionary(base::DictionaryValue* value);

@@ -124,12 +124,12 @@ class AppLauncherHandler

void PromptToEnableApp(const std::string& extension_id);

// ExtensionUninstallDialog::Delegate:

- virtual void ExtensionUninstallAccepted() override;

- virtual void ExtensionUninstallCanceled() override;

+ void ExtensionUninstallAccepted() override;

+ void ExtensionUninstallCanceled() override;

// ExtensionEnableFlowDelegate:

- virtual void ExtensionEnableFlowFinished() override;

- virtual void ExtensionEnableFlowAborted(bool user_initiated) override;

+ void ExtensionEnableFlowFinished() override;

+ void ExtensionEnableFlowAborted(bool user_initiated) override;

// Returns the ExtensionUninstallDialog object for this class, creating it if

// needed.