chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/status_icons/status_tray_mac.h ('k') | chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

diff --git a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

index 5a59fdd5facf2627e0d3af6ce3324e6433ae38c5..0611acc90ae25e75a040d07b8f226051fcf61050 100644

--- a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

+++ b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

@@ -28,22 +28,20 @@ class ChromeWebContentsViewDelegateMac

public ContextMenuDelegate {

public:

explicit ChromeWebContentsViewDelegateMac(content::WebContents* web_contents);

- virtual ~ChromeWebContentsViewDelegateMac();

+ ~ChromeWebContentsViewDelegateMac() override;

// Overridden from WebContentsViewDelegate:

- virtual NSObject<RenderWidgetHostViewMacDelegate>*

- CreateRenderWidgetHostViewDelegate(

- content::RenderWidgetHost* render_widget_host) override;

- virtual content::WebDragDestDelegate* GetDragDestDelegate() override;

- virtual void ShowContextMenu(

- content::RenderFrameHost* render_frame_host,

- const content::ContextMenuParams& params) override;

+ NSObject<RenderWidgetHostViewMacDelegate>* CreateRenderWidgetHostViewDelegate(

+ content::RenderWidgetHost* render_widget_host) override;

+ content::WebDragDestDelegate* GetDragDestDelegate() override;

+ void ShowContextMenu(content::RenderFrameHost* render_frame_host,

+ const content::ContextMenuParams& params) override;

// Overridden from ContextMenuDelegate.

- virtual scoped_ptr<RenderViewContextMenu> BuildMenu(

+ scoped_ptr<RenderViewContextMenu> BuildMenu(

content::WebContents* web_contents,

const content::ContextMenuParams& params) override;

- virtual void ShowMenu(scoped_ptr<RenderViewContextMenu> menu) override;

+ void ShowMenu(scoped_ptr<RenderViewContextMenu> menu) override;

private:

content::RenderWidgetHostView* GetActiveRenderWidgetHostView();