Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
index dbc3f71a14f5fbb1e4d53dd22ff887982e75c998..89a32256754bb8fbd5ca3ae3965ee48d4a184752 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
@@ -99,16 +99,16 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
Profile* profile,
ContentSettingsType content_type);
- virtual ~ContentSettingBubbleModel();
+ ~ContentSettingBubbleModel() override;
ContentSettingsType content_type() const { return content_type_; }
const BubbleContent& bubble_content() const { return bubble_content_; }
// content::NotificationObserver:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
virtual void OnRadioClicked(int radio_index) {}
virtual void OnPopupClicked(int index) {}
@@ -189,7 +189,7 @@ class ContentSettingTitleAndLinkModel : public ContentSettingBubbleModel {
content::WebContents* web_contents,
Profile* profile,
ContentSettingsType content_type);
- virtual ~ContentSettingTitleAndLinkModel() {}
+ ~ContentSettingTitleAndLinkModel() override {}
Delegate* delegate() const { return delegate_; }
private:
@@ -198,8 +198,8 @@ class ContentSettingTitleAndLinkModel : public ContentSettingBubbleModel {
void SetLearnMoreLink();
// content::ContentSettingBubbleModel:
- virtual void OnManageLinkClicked() override;
- virtual void OnLearnMoreLinkClicked() override;
+ void OnManageLinkClicked() override;
+ void OnLearnMoreLinkClicked() override;
Delegate* delegate_;
};
@@ -211,8 +211,8 @@ class ContentSettingRPHBubbleModel : public ContentSettingTitleAndLinkModel {
ProtocolHandlerRegistry* registry,
ContentSettingsType content_type);
- virtual void OnRadioClicked(int radio_index) override;
- virtual void OnDoneClicked() override;
+ void OnRadioClicked(int radio_index) override;
+ void OnDoneClicked() override;
private:
// These states must match the order of appearance of the radio buttons

Powered by Google App Engine
This is Rietveld 408576698