chrome/browser/ui/fast_unload_controller.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fast_unload_controller.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/fast_unload_controller.h ('k') | chrome/browser/ui/find_bar/find_bar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fast_unload_controller.cc

diff --git a/chrome/browser/ui/fast_unload_controller.cc b/chrome/browser/ui/fast_unload_controller.cc

index 65b988b46978f2433ad011c3cb7b7e6392ddd9fd..566a136f569497195bc2e42cf3ede4390cf73a65 100644

--- a/chrome/browser/ui/fast_unload_controller.cc

+++ b/chrome/browser/ui/fast_unload_controller.cc

@@ -29,15 +29,15 @@ class FastUnloadController::DetachedWebContentsDelegate

: public content::WebContentsDelegate {

public:

DetachedWebContentsDelegate() { }

- virtual ~DetachedWebContentsDelegate() { }

+ ~DetachedWebContentsDelegate() override {}

private:

// WebContentsDelegate implementation.

- virtual bool ShouldSuppressDialogs() override {

+ bool ShouldSuppressDialogs() override {

return true; // Return true so dialogs are suppressed.

}

- virtual void CloseContents(content::WebContents* source) override {

+ void CloseContents(content::WebContents* source) override {

// Finished detached close.

// FastUnloadController will observe

// |NOTIFICATION_WEB_CONTENTS_DISCONNECTED|.