chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/wrench_menu/recent_tabs_menu_model_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

index cce64829577529c4c31731d29e6da1e5ad0482bc..9ede7f222a3bcae765d909437dc12eddb91ffdef 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

@@ -101,7 +101,7 @@ class WebContents;

class WebsiteSettingsUIBridge : public WebsiteSettingsUI {

public:

WebsiteSettingsUIBridge();

- virtual ~WebsiteSettingsUIBridge();

+ ~WebsiteSettingsUIBridge() override;

// Creates a |WebsiteSettingsBubbleController| and displays the UI. |parent|

// contains the currently active window, |profile| contains the currently

@@ -118,12 +118,12 @@ class WebsiteSettingsUIBridge : public WebsiteSettingsUI {

WebsiteSettingsBubbleController* bubble_controller);

// WebsiteSettingsUI implementations.

- virtual void SetCookieInfo(const CookieInfoList& cookie_info_list) override;

- virtual void SetPermissionInfo(

+ void SetCookieInfo(const CookieInfoList& cookie_info_list) override;

+ void SetPermissionInfo(

const PermissionInfoList& permission_info_list) override;

- virtual void SetIdentityInfo(const IdentityInfo& identity_info) override;

- virtual void SetFirstVisit(const base::string16& first_visit) override;

- virtual void SetSelectedTab(TabId tab_id) override;

+ void SetIdentityInfo(const IdentityInfo& identity_info) override;

+ void SetFirstVisit(const base::string16& first_visit) override;

+ void SetSelectedTab(TabId tab_id) override;

private:

// The Cocoa controller for the bubble UI.