Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2700)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
index b2a25e087b18ff026c7f75524a2f222dca8df585..3285fc95a2e5b0b3842a237b6d926b5612bdfbda 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm
@@ -123,70 +123,66 @@ class BookmarkEditorBaseControllerBridge : public BookmarkModelObserver {
importing_(false)
{ }
- virtual void BookmarkModelLoaded(BookmarkModel* model,
- bool ids_reassigned) override {
+ void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override {
[controller_ modelChangedPreserveSelection:YES];
}
- virtual void BookmarkNodeMoved(BookmarkModel* model,
- const BookmarkNode* old_parent,
- int old_index,
- const BookmarkNode* new_parent,
- int new_index) override {
+ void BookmarkNodeMoved(BookmarkModel* model,
+ const BookmarkNode* old_parent,
+ int old_index,
+ const BookmarkNode* new_parent,
+ int new_index) override {
if (!importing_ && new_parent->GetChild(new_index)->is_folder())
[controller_ modelChangedPreserveSelection:YES];
}
- virtual void BookmarkNodeAdded(BookmarkModel* model,
- const BookmarkNode* parent,
- int index) override {
+ void BookmarkNodeAdded(BookmarkModel* model,
+ const BookmarkNode* parent,
+ int index) override {
if (!importing_ && parent->GetChild(index)->is_folder())
[controller_ modelChangedPreserveSelection:YES];
}
- virtual void BookmarkNodeRemoved(
- BookmarkModel* model,
- const BookmarkNode* parent,
- int old_index,
- const BookmarkNode* node,
- const std::set<GURL>& removed_urls) override {
+ void BookmarkNodeRemoved(BookmarkModel* model,
+ const BookmarkNode* parent,
+ int old_index,
+ const BookmarkNode* node,
+ const std::set<GURL>& removed_urls) override {
[controller_ nodeRemoved:node fromParent:parent];
if (node->is_folder())
[controller_ modelChangedPreserveSelection:NO];
}
- virtual void BookmarkAllUserNodesRemoved(
+ void BookmarkAllUserNodesRemoved(
BookmarkModel* model,
const std::set<GURL>& removed_urls) override {
[controller_ modelChangedPreserveSelection:NO];
}
- virtual void BookmarkNodeChanged(BookmarkModel* model,
- const BookmarkNode* node) override {
+ void BookmarkNodeChanged(BookmarkModel* model,
+ const BookmarkNode* node) override {
if (!importing_ && node->is_folder())
[controller_ modelChangedPreserveSelection:YES];
}
- virtual void BookmarkNodeChildrenReordered(
- BookmarkModel* model,
- const BookmarkNode* node) override {
+ void BookmarkNodeChildrenReordered(BookmarkModel* model,
+ const BookmarkNode* node) override {
if (!importing_)
[controller_ modelChangedPreserveSelection:YES];
}
- virtual void BookmarkNodeFaviconChanged(BookmarkModel* model,
- const BookmarkNode* node) override {
+ void BookmarkNodeFaviconChanged(BookmarkModel* model,
+ const BookmarkNode* node) override {
// I care nothing for these 'favicons': I only show folders.
}
- virtual void ExtensiveBookmarkChangesBeginning(
- BookmarkModel* model) override {
+ void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override {
importing_ = true;
}
// Invoked after a batch import finishes. This tells observers to update
// themselves if they were waiting for the update to finish.
- virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override {
+ void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override {
importing_ = false;
[controller_ modelChangedPreserveSelection:YES];
}

Powered by Google App Engine
This is Rietveld 408576698