chrome/browser/ui/webui/ntp/favicon_webui_handler.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/ntp/favicon_webui_handler.h ('k') | chrome/browser/ui/webui/ntp/foreign_session_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc b/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

index 262bc8d2ff8b8c163ef7a1f4c432f4f3f82d06fd..d0117449c1a6369090c13a7622f8f916fb486134 100644

--- a/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

+++ b/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

@@ -49,10 +49,10 @@ class ExtensionIconColorManager : public ExtensionIconManager {

explicit ExtensionIconColorManager(FaviconWebUIHandler* handler)

: ExtensionIconManager(),

handler_(handler) {}

- virtual ~ExtensionIconColorManager() {}

+ ~ExtensionIconColorManager() override {}

- virtual void OnImageLoaded(const std::string& extension_id,

- const gfx::Image& image) override {

+ void OnImageLoaded(const std::string& extension_id,

+ const gfx::Image& image) override {

ExtensionIconManager::OnImageLoaded(extension_id, image);

handler_->NotifyAppIconReady(extension_id);

}