chrome/browser/ui/location_bar/origin_chip_info_unittest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/location_bar/origin_chip_info_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/location_bar/location_bar_browsertest.cc ('k') | chrome/browser/ui/login/login_interstitial_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/location_bar/origin_chip_info_unittest.cc

diff --git a/chrome/browser/ui/location_bar/origin_chip_info_unittest.cc b/chrome/browser/ui/location_bar/origin_chip_info_unittest.cc

index f1eec2630fe11325beb8a201d32a4c706c400ee6..5f63c3b22edd92de0f5ef110d602ebbab84c0cf8 100644

--- a/chrome/browser/ui/location_bar/origin_chip_info_unittest.cc

+++ b/chrome/browser/ui/location_bar/origin_chip_info_unittest.cc

@@ -70,8 +70,7 @@ class OriginChipInfoTest : public ChromeRenderViewHostTestHarness,

ChromeRenderViewHostTestHarness::TearDown();

}

- virtual void OnExtensionIconImageChanged(

- extensions::IconImage* image) override {

+ void OnExtensionIconImageChanged(extensions::IconImage* image) override {

// We keep the value of |image| to check if it's set, but the actual value

// is never used.

icon_image_ = image;