chrome/browser/ui/cocoa/download/download_shelf_mac.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_mac.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/cocoa/download/download_item_mac.h ('k') | chrome/browser/ui/cocoa/extensions/browser_action_button.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_shelf_mac.h

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_mac.h b/chrome/browser/ui/cocoa/download/download_shelf_mac.h

index ada293f5437993c418b30ed90ec810590d5fd6b4..903e39ff44b91657720cf738cdc82763933baf94 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_mac.h

+++ b/chrome/browser/ui/cocoa/download/download_shelf_mac.h

@@ -22,14 +22,14 @@ class DownloadShelfMac : public DownloadShelf {

DownloadShelfMac(Browser* browser, DownloadShelfController* controller);

// DownloadShelf implementation.

- virtual bool IsShowing() const override;

- virtual bool IsClosing() const override;

- virtual Browser* browser() const override;

+ bool IsShowing() const override;

+ bool IsClosing() const override;

+ Browser* browser() const override;

protected:

- virtual void DoAddDownload(content::DownloadItem* download) override;

- virtual void DoShow() override;

- virtual void DoClose(CloseReason reason) override;

+ void DoAddDownload(content::DownloadItem* download) override;

+ void DoShow() override;

+ void DoClose(CloseReason reason) override;

private:

// The browser that owns this shelf.