chrome/browser/ui/webui/sync_setup_handler.h - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/sync_internals_ui.h ('k') | chrome/browser/ui/webui/sync_setup_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_setup_handler.h

diff --git a/chrome/browser/ui/webui/sync_setup_handler.h b/chrome/browser/ui/webui/sync_setup_handler.h

index e0b3ba3732d5af324273c6844c011b7029141958..d94c67bd5fd27d7b889577c2d73c16b2d8937aea 100644

--- a/chrome/browser/ui/webui/sync_setup_handler.h

+++ b/chrome/browser/ui/webui/sync_setup_handler.h

@@ -27,20 +27,19 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,

public:

// Constructs a new SyncSetupHandler. |profile_manager| may be NULL.

explicit SyncSetupHandler(ProfileManager* profile_manager);

- virtual ~SyncSetupHandler();

+ ~SyncSetupHandler() override;

// OptionsPageUIHandler implementation.

- virtual void GetLocalizedValues(base::DictionaryValue* localized_strings)

- override;

- virtual void RegisterMessages() override;

+ void GetLocalizedValues(base::DictionaryValue* localized_strings) override;

+ void RegisterMessages() override;

// SyncStartupTracker::Observer implementation;

- virtual void SyncStartupCompleted() override;

- virtual void SyncStartupFailed() override;

+ void SyncStartupCompleted() override;

+ void SyncStartupFailed() override;

// LoginUIService::LoginUI implementation.

- virtual void FocusUI() override;

- virtual void CloseUI() override;

+ void FocusUI() override;

+ void CloseUI() override;

static void GetStaticLocalizedValues(

base::DictionaryValue* localized_strings,