chrome/browser/ui/webui/signin/login_ui_service_unittest.cc - Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service_unittest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/android/tab_model/tab_model.h ('K') | « chrome/browser/ui/webui/signin/login_ui_service_factory.h ('k') | chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/login_ui_service_unittest.cc

diff --git a/chrome/browser/ui/webui/signin/login_ui_service_unittest.cc b/chrome/browser/ui/webui/signin/login_ui_service_unittest.cc

index c46b9e6c06f623d8c982f64e6f68b5378f87620a..beb542ed071fe8cc2875588e2ac386157362dd8c 100644

--- a/chrome/browser/ui/webui/signin/login_ui_service_unittest.cc

+++ b/chrome/browser/ui/webui/signin/login_ui_service_unittest.cc

@@ -11,9 +11,9 @@

class TestLoginUI : public LoginUIService::LoginUI {

public:

TestLoginUI() { }

- virtual ~TestLoginUI() { }

- virtual void FocusUI() override { }

- virtual void CloseUI() override { }

+ ~TestLoginUI() override {}

+ void FocusUI() override {}

+ void CloseUI() override {}

private:

DISALLOW_COPY_AND_ASSIGN(TestLoginUI);

@@ -29,11 +29,11 @@ class TestObserver : public LoginUIService::Observer {

int ui_closed_count() const { return ui_closed_count_; }

private:

- virtual void OnLoginUIShown(LoginUIService::LoginUI* ui) override {

+ void OnLoginUIShown(LoginUIService::LoginUI* ui) override {

++ui_shown_count_;

}

- virtual void OnLoginUIClosed(LoginUIService::LoginUI* ui) override {

+ void OnLoginUIClosed(LoginUIService::LoginUI* ui) override {

++ui_closed_count_;

}