Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/browser/ui/panels/panel_host.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_host.h
diff --git a/chrome/browser/ui/panels/panel_host.h b/chrome/browser/ui/panels/panel_host.h
index 1a1a27463766b90a989ffd210a8de0fa52564f93..2854516db1294720361adb6ee40e6cbb8151a007 100644
--- a/chrome/browser/ui/panels/panel_host.h
+++ b/chrome/browser/ui/panels/panel_host.h
@@ -38,7 +38,7 @@ class PanelHost : public content::WebContentsDelegate,
public extensions::ExtensionFunctionDispatcher::Delegate {
public:
PanelHost(Panel* panel, Profile* profile);
- virtual ~PanelHost();
+ ~PanelHost() override;
void Init(const GURL& url);
content::WebContents* web_contents() { return web_contents_.get(); }
@@ -48,46 +48,42 @@ class PanelHost : public content::WebContentsDelegate,
gfx::Image GetPageIcon() const;
// content::WebContentsDelegate overrides.
- virtual content::WebContents* OpenURLFromTab(
+ content::WebContents* OpenURLFromTab(
content::WebContents* source,
const content::OpenURLParams& params) override;
- virtual void NavigationStateChanged(
- const content::WebContents* source,
- content::InvalidateTypes changed_flags) override;
- virtual void AddNewContents(content::WebContents* source,
- content::WebContents* new_contents,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
- bool user_gesture,
- bool* was_blocked) override;
- virtual void ActivateContents(content::WebContents* contents) override;
- virtual void DeactivateContents(content::WebContents* contents) override;
- virtual void LoadingStateChanged(content::WebContents* source,
- bool to_different_document) override;
- virtual void CloseContents(content::WebContents* source) override;
- virtual void MoveContents(content::WebContents* source,
- const gfx::Rect& pos) override;
- virtual bool IsPopupOrPanel(
- const content::WebContents* source) const override;
- virtual void ContentsZoomChange(bool zoom_in) override;
- virtual void HandleKeyboardEvent(
+ void NavigationStateChanged(const content::WebContents* source,
+ content::InvalidateTypes changed_flags) override;
+ void AddNewContents(content::WebContents* source,
+ content::WebContents* new_contents,
+ WindowOpenDisposition disposition,
+ const gfx::Rect& initial_pos,
+ bool user_gesture,
+ bool* was_blocked) override;
+ void ActivateContents(content::WebContents* contents) override;
+ void DeactivateContents(content::WebContents* contents) override;
+ void LoadingStateChanged(content::WebContents* source,
+ bool to_different_document) override;
+ void CloseContents(content::WebContents* source) override;
+ void MoveContents(content::WebContents* source,
+ const gfx::Rect& pos) override;
+ bool IsPopupOrPanel(const content::WebContents* source) const override;
+ void ContentsZoomChange(bool zoom_in) override;
+ void HandleKeyboardEvent(
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) override;
- virtual void WebContentsFocused(content::WebContents* contents) override;
- virtual void ResizeDueToAutoResize(content::WebContents* web_contents,
- const gfx::Size& new_size) override;
+ void WebContentsFocused(content::WebContents* contents) override;
+ void ResizeDueToAutoResize(content::WebContents* web_contents,
+ const gfx::Size& new_size) override;
// content::WebContentsObserver overrides.
- virtual void RenderViewCreated(
- content::RenderViewHost* render_view_host) override;
- virtual void RenderProcessGone(base::TerminationStatus status) override;
- virtual void WebContentsDestroyed() override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ void RenderViewCreated(content::RenderViewHost* render_view_host) override;
+ void RenderProcessGone(base::TerminationStatus status) override;
+ void WebContentsDestroyed() override;
+ bool OnMessageReceived(const IPC::Message& message) override;
// extensions::ExtensionFunctionDispatcher::Delegate overrides.
- virtual extensions::WindowController* GetExtensionWindowController() const
- override;
- virtual content::WebContents* GetAssociatedWebContents() const override;
+ extensions::WindowController* GetExtensionWindowController() const override;
+ content::WebContents* GetAssociatedWebContents() const override;
// Actions on web contents.
void Reload();

Powered by Google App Engine
This is Rietveld 408576698