Issue 6715029: Fix crash in Debug::SendCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6715029: Fix crash in Debug::SendCommand. (Closed)

Created:
9 years, 9 months ago by podivilov

Modified:
9 years, 4 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix crash in Debug::SendCommand. R=vitalyr@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7310

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
	M	include/v8-debug.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	src/api.cc	View		1 chunk	+11 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 9 months ago (2011-03-22 15:54:10 UTC) #2

LGTM

http://codereview.chromium.org/6715029/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6715029/diff/1/src/api.cc#newcode4910
src/api.cc:4910: i::Isolate* internal_isolate =
reinterpret_cast<i::Isolate*>(isolate);
Replace tabs with spaces and fix indentation.

Expand Messages | Collapse Messages