Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: include/v8-debug.h

Issue 6715029: Fix crash in Debug::SendCommand. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 // EventDetails to EventCallback at the moment when the VM actually 269 // EventDetails to EventCallback at the moment when the VM actually
270 // stops. If no isolate is provided the default isolate is used. 270 // stops. If no isolate is provided the default isolate is used.
271 static void DebugBreakForCommand(ClientData* data = NULL, 271 static void DebugBreakForCommand(ClientData* data = NULL,
272 Isolate* isolate = NULL); 272 Isolate* isolate = NULL);
273 273
274 // Message based interface. The message protocol is JSON. NOTE the message 274 // Message based interface. The message protocol is JSON. NOTE the message
275 // handler thread is not supported any more parameter must be false. 275 // handler thread is not supported any more parameter must be false.
276 static void SetMessageHandler(MessageHandler handler, 276 static void SetMessageHandler(MessageHandler handler,
277 bool message_handler_thread = false); 277 bool message_handler_thread = false);
278 static void SetMessageHandler2(MessageHandler2 handler); 278 static void SetMessageHandler2(MessageHandler2 handler);
279
280 // If no isolate is provided the default isolate is
281 // used.
279 static void SendCommand(const uint16_t* command, int length, 282 static void SendCommand(const uint16_t* command, int length,
280 ClientData* client_data = NULL); 283 ClientData* client_data = NULL,
284 Isolate* isolate = NULL);
281 285
282 // Dispatch interface. 286 // Dispatch interface.
283 static void SetHostDispatchHandler(HostDispatchHandler handler, 287 static void SetHostDispatchHandler(HostDispatchHandler handler,
284 int period = 100); 288 int period = 100);
285 289
286 /** 290 /**
287 * Register a callback function to be called when a debug message has been 291 * Register a callback function to be called when a debug message has been
288 * received and is ready to be processed. For the debug messages to be 292 * received and is ready to be processed. For the debug messages to be
289 * processed V8 needs to be entered, and in certain embedding scenarios this 293 * processed V8 needs to be entered, and in certain embedding scenarios this
290 * callback can be used to make sure V8 is entered for the debug message to 294 * callback can be used to make sure V8 is entered for the debug message to
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 }; 385 };
382 386
383 387
384 } // namespace v8 388 } // namespace v8
385 389
386 390
387 #undef EXPORT 391 #undef EXPORT
388 392
389 393
390 #endif // V8_V8_DEBUG_H_ 394 #endif // V8_V8_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698