Issue 6714030: Cleanup preserved lib locking in portage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6714030: Cleanup preserved lib locking in portage. (Closed)

Created:
9 years, 9 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
zmedico

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Cleanup preserved lib locking in portage. This change makes preserved lib modification atomic, and prepares us for narrowing the scope of the merge lock. R=zmedico@gmail.com BUG= TEST=

Patch Set 1 : Remove extra newlines #

Patch Set 2 : More conservative locking. #

Patch Set 3 : Cleanup, rebase against other patch #

Patch Set 4 : Rebase #

Patch Set 5 : Remove lock changes #

Patch Set 6 : Kill extra tab, rebase again #

Patch Set 7 : Fix typos #

Patch Set 8 : Simplify #

Patch Set 9 : Rebase #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -120 lines)			Patch
M	pym/_emerge/actions.py	View	1 2 3 4 5 6 7 8	1 chunk	+0 lines, -7 lines	0 comments	Download
M	pym/_emerge/main.py	View	1 2 3 4 5 6 7 8	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pym/portage/dbapi/vartree.py	View	1 2 3 4 5 6 7	9 chunks	+70 lines, -96 lines	0 comments	Download
M	pym/portage/util/_dyn_libs/PreservedLibsRegistry.py	View	1 2 3 4 5 6 7	5 chunks	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

zmedico

9 years, 8 months ago (2011-04-28 21:01:38 UTC) #1

All _linkmap_rebuild calls belong within the scope of the plib_registry lock.
This requirement is not satisfied in the case where _prune_plib_registry relies
on a prior call to _linkmap_rebuild.

Expand Messages | Collapse Messages