Issue 6712007: Check for a missing scheme in the input_api.host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6712007: Check for a missing scheme in the input_api.host. (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
chase, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Check for a missing scheme in the input_api.host. R=chase@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78599

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+6 lines, -2 lines	2 comments	Download
	M	tests/presubmit_unittest.py	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6712007/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/6712007/diff/1/presubmit_canned_checks.py#newcode658 presubmit_canned_checks.py:658: # TODO(dpranke): Should figure out if input_api.host_url is supposed ...

9 years, 9 months ago (2011-03-17 19:12:54 UTC) #2

M-A Ruel

9 years, 9 months ago (2011-03-17 19:43:34 UTC) #3

lgtm, https can be enabled after.

http://codereview.chromium.org/6712007/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/6712007/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:661: if not host.startswith('http://'):
Some host are https:// only, please take that in account.

Expand Messages | Collapse Messages