Check for a missing scheme in the input_api.host.

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
   """Requires that the changelist have a TEST= field."""
@@ skipping 637 matching lines @@
     return []
 
   suggested_reviewers = owners_db.reviewers_for(affected_files)
   return [output_api.PresubmitAddReviewers(suggested_reviewers)]
 
 
 def _Approvers(input_api, email_regexp):
   if not input_api.change.issue:
     return []
 
-  path = '/api/%s?messages=true'
-  url = (input_api.host_url + path) % input_api.change.issue
+  # TODO(dpranke): Should figure out if input_api.host_url is supposed to

[M-A Ruel, 2011/03/17 19:12:54]

There's also the problem that some issues needs to be a authenticated request,
e.g. have a valid credential to request the api url.

+  # be a host or a scheme+host and normalize it there.
+  host = input_api.host_url
+  if not host.startswith('http://'):

[M-A Ruel, 2011/03/17 19:43:34]

Some host are https:// only, please take that in account.

+    host = 'http://' + host
+  url = '%s/api/%s?messages=true' % (host, input_api.change.issue)
 
   f = input_api.urllib2.urlopen(url)
   issue_props = input_api.json.load(f)
   owner = input_api.re.escape(issue_props['owner'])
 
   # TODO(dpranke): This mimics the logic in
   # /tools/commit-queue/verifiers/reviewer_lgtm.py
   # We should share the code and/or remove the check there where it is
   # redundant (since the commit queue also enforces the presubmit checks).
   def match_reviewer(r):
     return email_regexp.match(r) and not input_api.re.match(owner, r)
 
   approvers = []
   for m in issue_props.get('messages', []):
     if 'lgtm' in m['text'].lower() and match_reviewer(m['sender']):
       approvers.append(m['sender'])
   return set(approvers)