Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 6711045: Use VbSharedData instead of VbNvStorage for fwb_tries and kernkey_vfy (Closed)

Created:
9 years, 9 months ago by Randall Spangler
Modified:
9 years, 7 months ago
Reviewers:
Duncan Laurie
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Use VbSharedData instead of VbNvStorage for fwb_tries and kernkey_vfy Change-Id: I5ed3509a9d4e578cd2e98f493dab59bc2fbd5827 R=dlaurie@chromium.org BUG=chrome-os-partner:2748 TEST=manual crossystem fwb_tries=3 (reboot) crossystem tried_fwb (should print 1) crossystem fwb_tries=0 (reboot) crossystem tried_fwb (should print 0) In dev mode... Boot a kernel signed with the same key as in the firmware crossystem kernkey_vfy (should print sig) Boot a kernel signed with a different key than the firmware crossystem kernkey_vfy (should print hash) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cabe6b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M firmware/include/vboot_nvstorage.h View 1 chunk +0 lines, -7 lines 0 comments Download
M firmware/lib/vboot_firmware.c View 1 chunk +0 lines, -1 line 0 comments Download
M firmware/lib/vboot_kernel.c View 1 chunk +0 lines, -3 lines 0 comments Download
M firmware/lib/vboot_nvstorage.c View 3 chunks +0 lines, -25 lines 0 comments Download
M host/lib/crossystem.c View 5 chunks +16 lines, -7 lines 0 comments Download
M tests/vboot_nvstorage_test.c View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
9 years, 9 months ago (2011-03-18 18:49:00 UTC) #1
Duncan Laurie
9 years, 9 months ago (2011-03-18 19:39:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698