Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: firmware/lib/vboot_nvstorage.c

Issue 6711045: Use VbSharedData instead of VbNvStorage for fwb_tries and kernkey_vfy (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « firmware/lib/vboot_kernel.c ('k') | host/lib/crossystem.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* Copyright (c) 2011 The Chromium OS Authors. All rights reserved. 1 /* Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. 3 * found in the LICENSE file.
4 */ 4 */
5 5
6 /* Non-volatile storage routines. 6 /* Non-volatile storage routines.
7 */ 7 */
8 8
9 #include "utility.h" 9 #include "utility.h"
10 #include "vboot_common.h" 10 #include "vboot_common.h"
11 #include "vboot_nvstorage.h" 11 #include "vboot_nvstorage.h"
12 12
13 /* Constants for NV storage. We use this rather than structs and 13 /* Constants for NV storage. We use this rather than structs and
14 * bitfields so the data format is consistent across platforms and 14 * bitfields so the data format is consistent across platforms and
15 * compilers. */ 15 * compilers. */
16 #define HEADER_OFFSET 0 16 #define HEADER_OFFSET 0
17 #define HEADER_MASK 0xC0 17 #define HEADER_MASK 0xC0
18 #define HEADER_SIGNATURE 0x40 18 #define HEADER_SIGNATURE 0x40
19 #define HEADER_FIRMWARE_SETTINGS_RESET 0x20 19 #define HEADER_FIRMWARE_SETTINGS_RESET 0x20
20 #define HEADER_KERNEL_SETTINGS_RESET 0x10 20 #define HEADER_KERNEL_SETTINGS_RESET 0x10
21 21
22 #define BOOT_OFFSET 1 22 #define BOOT_OFFSET 1
23 #define BOOT_DEBUG_RESET_MODE 0x80 23 #define BOOT_DEBUG_RESET_MODE 0x80
24 #define BOOT_TRY_B_COUNT_MASK 0x0F 24 #define BOOT_TRY_B_COUNT_MASK 0x0F
25 25
26 #define RECOVERY_OFFSET 2 26 #define RECOVERY_OFFSET 2
27 #define LOCALIZATION_OFFSET 3 27 #define LOCALIZATION_OFFSET 3
28 28
29 #define FIRMWARE_FLAGS_OFFSET 5 29 #define FIRMWARE_FLAGS_OFFSET 5
30 #define FIRMWARE_TRIED_FIRMWARE_B 0x80
31 #define FIRMWARE_FW_VERIFIED_KERNEL_KEY 0x40
32 #define FIRMWARE_TEST_ERR_FUNC_MASK 0x38 30 #define FIRMWARE_TEST_ERR_FUNC_MASK 0x38
33 #define FIRMWARE_TEST_ERR_FUNC_SHIFT 3 31 #define FIRMWARE_TEST_ERR_FUNC_SHIFT 3
34 #define FIRMWARE_TEST_ERR_NUM_MASK 0x07 32 #define FIRMWARE_TEST_ERR_NUM_MASK 0x07
35 33
36 #define KERNEL_FIELD_OFFSET 11 34 #define KERNEL_FIELD_OFFSET 11
37 #define CRC_OFFSET 15 35 #define CRC_OFFSET 15
38 36
39 37
40 /* Return CRC-8 of the data, using x^8 + x^2 + x + 1 polynomial. A 38 /* Return CRC-8 of the data, using x^8 + x^2 + x + 1 polynomial. A
41 * table-based algorithm would be faster, but for only 15 bytes isn't 39 * table-based algorithm would be faster, but for only 15 bytes isn't
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 *dest = raw[LOCALIZATION_OFFSET]; 119 *dest = raw[LOCALIZATION_OFFSET];
122 return 0; 120 return 0;
123 121
124 case VBNV_KERNEL_FIELD: 122 case VBNV_KERNEL_FIELD:
125 *dest = (raw[KERNEL_FIELD_OFFSET] 123 *dest = (raw[KERNEL_FIELD_OFFSET]
126 | (raw[KERNEL_FIELD_OFFSET + 1] << 8) 124 | (raw[KERNEL_FIELD_OFFSET + 1] << 8)
127 | (raw[KERNEL_FIELD_OFFSET + 2] << 16) 125 | (raw[KERNEL_FIELD_OFFSET + 2] << 16)
128 | (raw[KERNEL_FIELD_OFFSET + 3] << 24)); 126 | (raw[KERNEL_FIELD_OFFSET + 3] << 24));
129 return 0; 127 return 0;
130 128
131 case VBNV_TRIED_FIRMWARE_B:
132 *dest = (raw[FIRMWARE_FLAGS_OFFSET] & FIRMWARE_TRIED_FIRMWARE_B ? 1 : 0);
133 return 0;
134
135 case VBNV_FW_VERIFIED_KERNEL_KEY:
136 *dest = (raw[FIRMWARE_FLAGS_OFFSET] & FIRMWARE_FW_VERIFIED_KERNEL_KEY ?
137 1 : 0);
138 return 0;
139
140 case VBNV_TEST_ERROR_FUNC: 129 case VBNV_TEST_ERROR_FUNC:
141 *dest = (raw[FIRMWARE_FLAGS_OFFSET] & FIRMWARE_TEST_ERR_FUNC_MASK) 130 *dest = (raw[FIRMWARE_FLAGS_OFFSET] & FIRMWARE_TEST_ERR_FUNC_MASK)
142 >> FIRMWARE_TEST_ERR_FUNC_SHIFT; 131 >> FIRMWARE_TEST_ERR_FUNC_SHIFT;
143 return 0; 132 return 0;
144 133
145 case VBNV_TEST_ERROR_NUM: 134 case VBNV_TEST_ERROR_NUM:
146 *dest = raw[FIRMWARE_FLAGS_OFFSET] & FIRMWARE_TEST_ERR_NUM_MASK; 135 *dest = raw[FIRMWARE_FLAGS_OFFSET] & FIRMWARE_TEST_ERR_NUM_MASK;
147 return 0; 136 return 0;
148 137
149 default: 138 default:
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 raw[LOCALIZATION_OFFSET] = (uint8_t)value; 195 raw[LOCALIZATION_OFFSET] = (uint8_t)value;
207 break; 196 break;
208 197
209 case VBNV_KERNEL_FIELD: 198 case VBNV_KERNEL_FIELD:
210 raw[KERNEL_FIELD_OFFSET] = (uint8_t)(value); 199 raw[KERNEL_FIELD_OFFSET] = (uint8_t)(value);
211 raw[KERNEL_FIELD_OFFSET + 1] = (uint8_t)(value >> 8); 200 raw[KERNEL_FIELD_OFFSET + 1] = (uint8_t)(value >> 8);
212 raw[KERNEL_FIELD_OFFSET + 2] = (uint8_t)(value >> 16); 201 raw[KERNEL_FIELD_OFFSET + 2] = (uint8_t)(value >> 16);
213 raw[KERNEL_FIELD_OFFSET + 3] = (uint8_t)(value >> 24); 202 raw[KERNEL_FIELD_OFFSET + 3] = (uint8_t)(value >> 24);
214 break; 203 break;
215 204
216 case VBNV_TRIED_FIRMWARE_B:
217 if (value)
218 raw[FIRMWARE_FLAGS_OFFSET] |= FIRMWARE_TRIED_FIRMWARE_B;
219 else
220 raw[FIRMWARE_FLAGS_OFFSET] &= ~FIRMWARE_TRIED_FIRMWARE_B;
221 break;
222
223 case VBNV_FW_VERIFIED_KERNEL_KEY:
224 if (value)
225 raw[FIRMWARE_FLAGS_OFFSET] |= FIRMWARE_FW_VERIFIED_KERNEL_KEY;
226 else
227 raw[FIRMWARE_FLAGS_OFFSET] &= ~FIRMWARE_FW_VERIFIED_KERNEL_KEY;
228 break;
229
230 case VBNV_TEST_ERROR_FUNC: 205 case VBNV_TEST_ERROR_FUNC:
231 raw[FIRMWARE_FLAGS_OFFSET] &= ~FIRMWARE_TEST_ERR_FUNC_MASK; 206 raw[FIRMWARE_FLAGS_OFFSET] &= ~FIRMWARE_TEST_ERR_FUNC_MASK;
232 raw[FIRMWARE_FLAGS_OFFSET] |= (value << FIRMWARE_TEST_ERR_FUNC_SHIFT) 207 raw[FIRMWARE_FLAGS_OFFSET] |= (value << FIRMWARE_TEST_ERR_FUNC_SHIFT)
233 & FIRMWARE_TEST_ERR_FUNC_MASK; 208 & FIRMWARE_TEST_ERR_FUNC_MASK;
234 break; 209 break;
235 210
236 case VBNV_TEST_ERROR_NUM: 211 case VBNV_TEST_ERROR_NUM:
237 raw[FIRMWARE_FLAGS_OFFSET] &= ~FIRMWARE_TEST_ERR_NUM_MASK; 212 raw[FIRMWARE_FLAGS_OFFSET] &= ~FIRMWARE_TEST_ERR_NUM_MASK;
238 raw[FIRMWARE_FLAGS_OFFSET] |= (value & FIRMWARE_TEST_ERR_NUM_MASK); 213 raw[FIRMWARE_FLAGS_OFFSET] |= (value & FIRMWARE_TEST_ERR_NUM_MASK);
239 break; 214 break;
240 215
241 default: 216 default:
242 return 1; 217 return 1;
243 } 218 }
244 219
245 /* Need to regenerate CRC, since the value changed. */ 220 /* Need to regenerate CRC, since the value changed. */
246 context->regenerate_crc = 1; 221 context->regenerate_crc = 1;
247 return 0; 222 return 0;
248 } 223 }
OLDNEW
« no previous file with comments | « firmware/lib/vboot_kernel.c ('k') | host/lib/crossystem.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698