Issue 6711013: Fix crash with pepper 3D on multiple windows in same renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6711013: Fix crash with pepper 3D on multiple windows in same renderer (Closed)

Created:
9 years, 9 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, jam, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash with pepper 3D on multiple windows in same renderer BUG=none TEST=With pepper flash, run ATS AS2 14231, open the popup, kill it, observe no crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78595

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -7 lines)			Patch
M	chrome/renderer/pepper_platform_context_3d_impl.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/pepper_platform_context_3d_impl.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	content/renderer/ggl.h	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	content/renderer/ggl.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

9 years, 9 months ago (2011-03-17 20:15:38 UTC) #2

lgtm

http://codereview.chromium.org/6711013/diff/1/content/renderer/ggl.h
File content/renderer/ggl.h (right):

http://codereview.chromium.org/6711013/diff/1/content/renderer/ggl.h#newcode147
content/renderer/ggl.h:147: base::WeakPtr<Context>
GetWeakContextReference(Context* context);
I regret making ggl c-style now :(

Expand Messages | Collapse Messages