Issue 67092: Matching v8 build settings more closely to try to fix regression in performan...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67092: Matching v8 build settings more closely to try to fix regression in performan... (Closed)

Created:
11 years, 8 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Mike Belshe, mbelshe, Kasper Lund

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Matching v8 build settings more closely to try to fix regression in performance. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13642

Patch Set 3 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	build/common.gypi	View	1 2	4 chunks	+13 lines, -7 lines	0 comments	Download
	M	build/temp_gyp/v8.gyp	View	1	5 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

I'm not sure I understand the changes. rubber stamp lgtm.

11 years, 8 months ago (2009-04-13 21:02:58 UTC) #2

Mark Mentovai

LG otherwise http://codereview.chromium.org/67092/diff/1/3 File build/common.gypi (right): http://codereview.chromium.org/67092/diff/1/3#newcode46 Line 46: 'msvs_local_release%': 0, The flow is weird ...

11 years, 8 months ago (2009-04-13 21:10:43 UTC) #3

bradn

11 years, 8 months ago (2009-04-13 23:10:42 UTC) #4

http://codereview.chromium.org/67092/diff/1/3
File build/common.gypi (right):

http://codereview.chromium.org/67092/diff/1/3#newcode46
Line 46: 'msvs_local_release%': 0,
On 2009/04/13 21:10:44, Mark Mentovai wrote:
> The flow is weird here.  If msvs_local_release is false, then we don't use
> release.vsprops?  I guess that depends on you being able to figure out what
> "local release" means.  I'd prefer seeing this as 'msvs_use_common_relese%':
1,
> where 1 (true) means YES, make common.gypi apply release.vsprops.

Done.

Expand Messages | Collapse Messages

Issue 67092: Matching v8 build settings more closely to try to fix regression in performan... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages