Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3420)

Unified Diff: build/temp_gyp/v8.gyp

Issue 67092: Matching v8 build settings more closely to try to fix regression in performan... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/temp_gyp/v8.gyp
===================================================================
--- build/temp_gyp/v8.gyp (revision 13611)
+++ build/temp_gyp/v8.gyp (working copy)
@@ -6,6 +6,7 @@
{
'variables': {
'chromium_code': 1,
+ 'msvs_use_common_release': 0,
'base_source_files': [
'../../v8/src/third_party/dtoa/dtoa.c',
'../../v8/src/accessors.cc',
@@ -275,6 +276,11 @@
],
}],
['OS=="win"', {
+ 'msvs_configuration_attributes': {
+ 'OutputDirectory': '$(SolutionDir)$(ConfigurationName)',
+ 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
+ 'CharacterSet': '1',
+ },
'msvs_settings': {
'VCCLCompilerTool': {
'RuntimeLibrary': '0',
@@ -398,7 +404,7 @@
]
}
],
- ['OS=="mac"',
+ ['OS=="mac"',
{
'sources/': [
['include', 'src/platform-macos\\.cc$'],
@@ -504,7 +510,9 @@
},
],
- 'conditions': [ ['OS!="linux"', { 'targets': [
+ 'conditions': [ ['OS=="mac"', { 'targets': [
+ # TODO(bradnelson): temporarily disable 'd8' target on Windows while
+ # we work fix the performance regressions.
# TODO(sgk): temporarily disable 'd8' target on Linux while
# we work out getting the readline library on all the systems.
{
@@ -659,8 +667,7 @@
['OS=="win"', {
'target_defaults': {
'defines': [
- '_USE_32BIT_TIME_T'
- 'PCRE_STATIC',
+ '_USE_32BIT_TIME_T',
'_CRT_SECURE_NO_DEPRECATE',
'_CRT_NONSTDC_NO_DEPRECATE',
],
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698