Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 6709009: Stop overloading Init() in NativeMetafile. (Closed)

Created:
9 years, 9 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Stop overloading Init() in NativeMetafile. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M chrome/browser/printing/print_view_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M printing/image.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/native_metafile.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_ps_metafile_cairo.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_ps_metafile_cairo.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M printing/pdf_ps_metafile_cairo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
vandebo (ex-Chrome)
9 years, 9 months ago (2011-03-17 21:55:06 UTC) #1
Lei Zhang
9 years, 9 months ago (2011-03-17 21:58:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698