chrome/browser/printing/print_view_manager.cc - Issue 6709009: Stop overloading Init() in NativeMetafile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 6709009: Stop overloading Init() in NativeMetafile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_view_manager.cc

diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc

index fa3ff5fdc8143a902da07da54c9618488fbbadb4..6c9bed088cc585bb687f980b1637365fd31aa01f 100644

--- a/chrome/browser/printing/print_view_manager.cc

+++ b/chrome/browser/printing/print_view_manager.cc

@@ -136,7 +136,7 @@ void PrintViewManager::OnDidPrintPage(

scoped_ptr<NativeMetafile> metafile(NativeMetafileFactory::CreateMetafile());

if (metafile_must_be_valid) {

- if (!metafile->Init(shared_buf.memory(), params.data_size)) {

+ if (!metafile->InitFromData(shared_buf.memory(), params.data_size)) {

NOTREACHED() << "Invalid metafile header";

tab_contents()->Stop();

return;

« no previous file with comments | « no previous file | chrome/common/common_param_traits.cc » ('j') | no next file with comments »