Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 6708108: Remove redundant usages of some macros and functions in debug.cc (Closed)

Created:
9 years, 9 months ago by Peter Varga
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove redundant usages of some macros and functions in debug.cc Cleanup of HEAP and FACTORY macros and use isolate_ member of classes where it is possible. Cleanup of debugger(), debug() and global_handles() functions. Pass the isolate pointer to the HandleScope constructor. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7416

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -96 lines) Patch
M src/debug.cc View 48 chunks +120 lines, -96 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Peter Varga
9 years, 9 months ago (2011-03-29 12:44:05 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-29 13:57:16 UTC) #2
LGTM, I will fix this comment and land.

http://codereview.chromium.org/6708108/diff/1/src/debug.cc
File src/debug.cc (right):

http://codereview.chromium.org/6708108/diff/1/src/debug.cc#newcode1038
src/debug.cc:1038: Factory* factory = Isolate::Current()->factory();
Use isolate_ here as well.

Powered by Google App Engine
This is Rietveld 408576698