Issue 6708033: Revert 74236 - Mac: Turn on tab overview mode by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6708033: Revert 74236 - Mac: Turn on tab overview mode by default. (Closed)

Created:
9 years, 9 months ago by sail

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Nico, viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 74236 - Mac: Turn on tab overview mode by default. BUG=50307, 72362, 76702 TEST=three-finger-swipe down and Window->Tab Overview both open tab overview mode Review URL: http://codereview.chromium.org/6459009 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78737

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

9 years, 9 months ago (2011-03-18 19:38:26 UTC) #3

LGTM.

I see that the tryserver couldn’t apply your patch. Make sure this is tested!