Issue 6459009: Mac: Turn on tab overview mode by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6459009: Mac: Turn on tab overview mode by default. (Closed)

Created:
9 years, 10 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Turn on tab overview mode by default. BUG=50307, 72362 TEST=three-finger-swipe down and Window->Tab Overview both open tab overview mode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74236

Patch Set 1 #

Total comments: 1

Patch Set 2 : mento wins again #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -32 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LG otherwise. http://codereview.chromium.org/6459009/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): http://codereview.chromium.org/6459009/diff/1/chrome/browser/about_flags.cc#oldcode74 chrome/browser/about_flags.cc:74: IDS_FLAGS_TABPOSE_NAME, Wanna kill these too?

9 years, 10 months ago (2011-02-09 01:23:17 UTC) #3

Mark Mentovai

9 years, 10 months ago (2011-02-09 02:16:23 UTC) #4

I guess the strings might be used elsewhere—I didn’t check. If they
are, LG as is.

Expand Messages | Collapse Messages