Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 67061: Fix ASSERTS in worker code in OSX.... (Closed)

Created:
11 years, 8 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
Reviewers:
jianli
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix ASSERTS in worker code in OSX. One issue was with using WTF::currentThread() from destructor of thread-specific data. In pthreads environment, this destructors are called after thread is detached and there is no ThreadIdentifier for it. Also moved the destruction of dom objects from thread-specific destructor time to WorkerScriptController destruction time - to prevent similar issues with WTF ThreadIdentifier since WorkerScriptController is destroyed before thread proc actually exits.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -41 lines) Patch
M third_party/WebKit/WebCore/bindings/v8/V8DOMMap.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/WebCore/bindings/v8/V8DOMMap.cpp View 1 7 chunks +21 lines, -30 lines 0 comments Download
M third_party/WebKit/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/WebCore/bindings/v8/WorkerScriptController.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Titov
11 years, 8 months ago (2009-04-10 23:38:47 UTC) #1
jianli
http://codereview.chromium.org/67061/diff/1/5 File third_party/WebKit/WebCore/bindings/v8/V8DOMMap.cpp (right): http://codereview.chromium.org/67061/diff/1/5#newcode109 Line 109: typedef WTF::Vector<ThreadSpecificDOMData*> DOMDataList; Could you please add include ...
11 years, 8 months ago (2009-04-11 18:16:28 UTC) #2
Dmitry Titov
> http://codereview.chromium.org/67061/diff/1/5#newcode109 > Line 109: typedef WTF::Vector<ThreadSpecificDOMData*> DOMDataList; > Could you please add include for ...
11 years, 8 months ago (2009-04-13 18:55:36 UTC) #3
Dmitry Titov
ready for another look. testing it in win32...
11 years, 8 months ago (2009-04-13 21:59:06 UTC) #4
jianli
11 years, 8 months ago (2009-04-13 22:02:31 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698