Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 6705004: Return the full cookie details in TestingAutomationProvider and pass around (Closed)

Created:
9 years, 9 months ago by kkania
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Return the full cookie details in TestingAutomationProvider and pass around a JSON dictionary instead of a cookie string. Deprecate the old JSON cookie interface, but do not remove because it is still being used by old automation servers. Will remove when version 12 reaches stable. Also fix the stack trace in response errors to conform to the spec. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79495

Patch Set 1 : ... #

Total comments: 1

Patch Set 2 : Version -> BrowserVersion #

Total comments: 2

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+542 lines, -206 lines) Patch
M chrome/browser/automation/automation_util.h View 1 chunk +3 lines, -17 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 9 chunks +107 lines, -29 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 2 2 chunks +33 lines, -8 lines 0 comments Download
M chrome/test/automation/automation_json_requests.h View 3 chunks +32 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_json_requests.cc View 3 chunks +44 lines, -0 lines 0 comments Download
M chrome/test/webdriver/WEBDRIVER_TESTS View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/webdriver/automation.h View 1 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/test/webdriver/automation.cc View 1 2 chunks +30 lines, -12 lines 0 comments Download
M chrome/test/webdriver/commands/cookie_commands.h View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/test/webdriver/commands/cookie_commands.cc View 1 7 chunks +174 lines, -104 lines 0 comments Download
M chrome/test/webdriver/commands/response.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M chrome/test/webdriver/commands/session_with_id.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/session.h View 1 2 chunks +18 lines, -6 lines 0 comments Download
M chrome/test/webdriver/session.cc View 1 5 chunks +66 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kkania
jleyba: chrome/test/webdriver/* jmikhail: everything else The Java tests (except for 2 that use localhost) and ...
9 years, 9 months ago (2011-03-22 21:59:26 UTC) #1
Jason Leyba
http://codereview.chromium.org/6705004/diff/3001/chrome/test/webdriver/session.cc File chrome/test/webdriver/session.cc (right): http://codereview.chromium.org/6705004/diff/3001/chrome/test/webdriver/session.cc#newcode542 chrome/test/webdriver/session.cc:542: bool Session::GetVersionAndCompare(int client_build_no, Rename this CompareVersion. Actually, to be ...
9 years, 9 months ago (2011-03-22 22:20:31 UTC) #2
kkania
fixed Jason's comments
9 years, 9 months ago (2011-03-22 22:33:20 UTC) #3
Jason Leyba
chrome/test/webdriver LGTM
9 years, 9 months ago (2011-03-22 22:37:16 UTC) #4
kkania
9 years, 9 months ago (2011-03-23 00:11:51 UTC) #5
Joe
With the new methods can we now get all of the cookies for a domain? ...
9 years, 9 months ago (2011-03-23 01:55:45 UTC) #6
Joe
With the new methods can we now get all of the cookies for a domain? ...
9 years, 9 months ago (2011-03-23 01:55:45 UTC) #7
kkania
Yes, you can get all the cookies for a domain (although I think the old ...
9 years, 9 months ago (2011-03-26 01:37:22 UTC) #8
kkania
Pawel, can you please review this when you get the chance? If you are busy, ...
9 years, 9 months ago (2011-03-26 01:38:30 UTC) #9
Joe
Ken was able to address all of my questions so LGTM On Fri, Mar 25, ...
9 years, 9 months ago (2011-03-26 03:38:59 UTC) #10
Paweł Hajdan Jr.
9 years, 9 months ago (2011-03-26 15:34:40 UTC) #11
Automation changes LGTM.

Powered by Google App Engine
This is Rietveld 408576698