Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/test/webdriver/commands/response.cc

Issue 6705004: Return the full cookie details in TestingAutomationProvider and pass around (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/response.cc
diff --git a/chrome/test/webdriver/commands/response.cc b/chrome/test/webdriver/commands/response.cc
index d25675472c4b27ad217114c5c336856c615c85d2..153e6b71a8234625197aa5353cf8bf8e1c64a479 100644
--- a/chrome/test/webdriver/commands/response.cc
+++ b/chrome/test/webdriver/commands/response.cc
@@ -19,8 +19,11 @@ const char* const kValueKey = "value";
const char* const kMessageKey = "message";
const char* const kScreenKey = "screen";
const char* const kClassKey = "class";
-const char* const kStackTraceFileNameKey = "stackTrace.fileName";
-const char* const kStackTraceLineNumberKey = "stackTrace.lineNumber";
+const char* const kStackTraceKey = "stackTrace";
+const char* const kStackTraceFileNameKey = "fileName";
+const char* const kStackTraceClassNameKey = "className";
+const char* const kStackTraceMethodNameKey = "methodName";
+const char* const kStackTraceLineNumberKey = "lineNumber";
} // namespace
@@ -57,8 +60,15 @@ void Response::SetError(ErrorCode error_code, const std::string& message,
const std::string& file, int line) {
DictionaryValue* error = new DictionaryValue;
error->SetString(kMessageKey, message);
- error->SetString(kStackTraceFileNameKey, file);
- error->SetInteger(kStackTraceLineNumberKey, line);
+
+ DictionaryValue* stack = new DictionaryValue;
+ stack->SetString(kStackTraceFileNameKey, file);
+ stack->SetString(kStackTraceClassNameKey, "");
+ stack->SetString(kStackTraceMethodNameKey, "");
+ stack->SetInteger(kStackTraceLineNumberKey, line);
+ ListValue* stack_list = new ListValue;
+ stack_list->Append(stack);
+ error->Set(kStackTraceKey, stack_list);
SetStatus(error_code);
SetValue(error);
@@ -75,4 +85,3 @@ std::string Response::ToJSON() const {
}
} // namespace webdriver
-
« no previous file with comments | « chrome/test/webdriver/commands/cookie_commands.cc ('k') | chrome/test/webdriver/commands/session_with_id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698