Add an exception wrapper to the WindowProc functions so...

Add an exception wrapper to the WindowProc functions so
that we receive crash reports when something goes wrong.

BUG=63702
TEST=base_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78475

[cpu_(ooo_6.6-7.5), 2011-03-16 00:09:22]

http://codereview.chromium.org/6697004/diff/1/chrome/app/breakpad_win.cc
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/6697004/diff/1/chrome/app/breakpad_win.cc#newc...
chrome/app/breakpad_win.cc:443: // for it to do anything.
should it be:
__declspec(dllexport) int __cdecl CrashForException(

Or the extern "C" here sufices? I am always fuzzy about the rules.

[cpu_(ooo_6.6-7.5), 2011-03-16 00:12:36]

http://codereview.chromium.org/6697004/diff/1/base/win/wrapped_window_proc.h
File base/win/wrapped_window_proc.h (right):

http://codereview.chromium.org/6697004/diff/1/base/win/wrapped_window_proc.h#...
base/win/wrapped_window_proc.h:52: template <WNDPROC proc>
it feels that we could do
template <WNDPROC proc, EXFILTER filter>

Or do we expect that we actually are going to switch filters at runtime? or for
it to be NULL ?

[rvargas (doing something else), 2011-03-16 00:25:07]

http://codereview.chromium.org/6697004/diff/1/base/win/wrapped_window_proc.h
File base/win/wrapped_window_proc.h (right):

http://codereview.chromium.org/6697004/diff/1/base/win/wrapped_window_proc.h#...
base/win/wrapped_window_proc.h:52: template <WNDPROC proc>
On 2011/03/16 00:12:37, cpu wrote:
> it feels that we could do
> template <WNDPROC proc, EXFILTER filter>
> 
> Or do we expect that we actually are going to switch filters at runtime? or
for
> it to be NULL ?

The idea is that the filter is not provided by the implementor of the
WindowProc... if they have to be aware of SEH and breakpad, we might as well
remove the template.

http://codereview.chromium.org/6697004/diff/1/chrome/app/breakpad_win.cc
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/6697004/diff/1/chrome/app/breakpad_win.cc#newc...
chrome/app/breakpad_win.cc:443: // for it to do anything.
Extern "C" is fine.

On 2011/03/16 00:09:22, cpu wrote:
> should it be:
> __declspec(dllexport) int __cdecl CrashForException(
> 
> Or the extern "C" here sufices? I am always fuzzy about the rules.

[cpu_(ooo_6.6-7.5), 2011-03-16 22:22:38]

lgtm