Add an exception wrapper to the WindowProc functions so...

chrome/app/breakpad_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/breakpad_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 #include <tchar.h>
 
@@ skipping 420 matching lines @@
   // If the UI layout is right-to-left, we need to pass the appropriate MB_XXX
   // flags so that an RTL message box is displayed.
   UINT flags = MB_OKCANCEL | MB_ICONWARNING;
   if (dlg_strings[2] == ASCIIToWide(env_vars::kRtlLocale))
     flags |= MB_RIGHT | MB_RTLREADING;
 
   return WrapMessageBoxWithSEH(dlg_strings[1].c_str(), dlg_strings[0].c_str(),
                                flags, exit_now);
 }
 
+// Crashes the process after generating a dump for the provided exception. Note
+// that the crash reporter should be initialized before calling this function
+// for it to do anything.

[cpu_(ooo_6.6-7.5), 2011/03/16 00:09:22]

should it be:
__declspec(dllexport) int __cdecl CrashForException(

Or the extern "C" here sufices? I am always fuzzy about the rules.

[rvargas (doing something else), 2011/03/16 00:25:07]

Extern "C" is fine.

On 2011/03/16 00:09:22, cpu wrote:

+extern "C" int __declspec(dllexport) CrashForException(
+    EXCEPTION_POINTERS* info) {
+  if (g_breakpad) {
+    g_breakpad->WriteMinidumpForException(info);
+    ::ExitProcess(ResultCodes::KILLED);
+  }
+  return EXCEPTION_CONTINUE_SEARCH;
+}
+
 // Determine whether configuration management allows loading the crash reporter.
 // Since the configuration management infrastructure is not initialized at this
 // point, we read the corresponding registry key directly. The return status
 // indicates whether policy data was successfully read. If it is true, |result|
 // contains the value set by policy.
 static bool MetricsReportingControlledByPolicy(bool* result) {
   std::wstring key_name = UTF8ToWide(policy::key::kMetricsReportingEnabled);
   DWORD value = 0;
   // TODO(joshia): why hkcu_policy_key opens HKEY_LOCAL_MACHINE?
   base::win::RegKey hkcu_policy_key(HKEY_LOCAL_MACHINE,
@@ skipping 151 matching lines @@
       if (QueueUserWorkItem(
               &InitCrashReporterThread,
               info,
               WT_EXECUTELONGFUNCTION) == 0) {
         // We failed to queue to the worker pool, initialize in this thread.
         InitCrashReporterThread(info);
       }
     }
   }
 }