src/ic.cc - Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates

Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index d3ff2d42c79925523909769e007c8d091a4e73a7..7e87b1b5fb45c315116a10cd16ce7cc6e8180ffa 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -946,7 +946,7 @@ MaybeObject* LoadIC::Load(State state,

if (FLAG_strict || IsContextual(object)) {

return ReferenceError("not_defined", name);

}

- LOG(SuspectReadEvent(*name, *object));

+ LOG(isolate(), SuspectReadEvent(*name, *object));

}

bool can_be_inlined_precheck =

« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »