src/ia32/assembler-ia32.cc - Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32.cc

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates

Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/assembler-ia32.cc

diff --git a/src/ia32/assembler-ia32.cc b/src/ia32/assembler-ia32.cc

index b7d05f5d36c5da48f713f6beabae2d5d75d89f22..b323f0997be723ea90b652377d17bb916637f7a0 100644

--- a/src/ia32/assembler-ia32.cc

+++ b/src/ia32/assembler-ia32.cc

@@ -129,7 +129,8 @@ void CpuFeatures::Probe(bool portable) {

}

if (!code->IsCode()) return;

- PROFILE(CodeCreateEvent(Logger::BUILTIN_TAG,

+ PROFILE(ISOLATE,

+ CodeCreateEvent(Logger::BUILTIN_TAG,

Code::cast(code), "CpuFeatures::Probe"));

typedef uint64_t (*F0)();

F0 probe = FUNCTION_CAST<F0>(Code::cast(code)->entry());

« no previous file with comments | « src/heap-profiler.cc ('k') | src/ia32/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »