Issue 6696037: Fix incorrect assumption on bit-and on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6696037: Fix incorrect assumption on bit-and on ARM (Closed)

Created:
9 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix incorrect assumption on bit-and on ARM Committed: http://code.google.com/p/v8/source/detail?r=7183

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	src/arm/codegen-arm.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	test/mjsunit/bitops-info.js	View		2 chunks	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 9 months ago (2011-03-15 21:53:15 UTC) #2

LGTM

http://codereview.chromium.org/6696037/diff/2002/test/mjsunit/bitops-info.js
File test/mjsunit/bitops-info.js (right):

http://codereview.chromium.org/6696037/diff/2002/test/mjsunit/bitops-info.js#...
test/mjsunit/bitops-info.js:41: var w = -0x20123456;  // A negative smi.
return

http://codereview.chromium.org/6696037/diff/2002/test/mjsunit/bitops-info.js#...
test/mjsunit/bitops-info.js:45: var w = hidden_negative_smi();  // Not a
constant.
you probably wanted to use it somewhere, but did not.

as it fails without w you can probably remove it.

Expand Messages | Collapse Messages