Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 6694009: refactor presubmit parsing code from git-cl into presubmit (Closed)

Created:
9 years, 9 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
chase, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

This change moves the code I added to git-cl to parse the results of the presubmit hooks into presubmit_support itself. It also removes a lot of the text-file parsing that is no longer necessary since everything is in process. It also simplifies all of the PresubmitResult* objects and the way we're using output streams since we can assume more about how the callers are calling us. Note that I uses PEP-8 style method names where I was adding entirely new classes (or rewriting existing classes completely) since per maruel@ he is trying to new that style for new code. This change also contains two small changes to git_cl to fix bugs and restore the previous behavior of --force skipping the presubmit checks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78328

Patch Set 1 #

Total comments: 1

Patch Set 2 : backport git-cl fixes from gcl_owners patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -214 lines) Patch
M gcl.py View 1 1 chunk +6 lines, -3 lines 0 comments Download
M git_cl/git_cl.py View 1 4 chunks +12 lines, -53 lines 0 comments Download
M presubmit_canned_checks.py View 1 chunk +1 line, -1 line 0 comments Download
M presubmit_support.py View 8 chunks +84 lines, -83 lines 0 comments Download
M tests/presubmit_unittest.py View 1 11 chunks +74 lines, -74 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
9 years, 9 months ago (2011-03-15 00:59:46 UTC) #1
chase
lgtm http://codereview.chromium.org/6694009/diff/1/tests/presubmit_unittest.py File tests/presubmit_unittest.py (right): http://codereview.chromium.org/6694009/diff/1/tests/presubmit_unittest.py#newcode602 tests/presubmit_unittest.py:602: 'Warning, no presubmit.py found.\n' indent +1
9 years, 9 months ago (2011-03-15 05:59:44 UTC) #2
M-A Ruel
lgtm
9 years, 9 months ago (2011-03-15 13:40:57 UTC) #3
Dirk Pranke
I backported the --force change and the other git-cl fix from the gcl change to ...
9 years, 9 months ago (2011-03-16 01:00:44 UTC) #4
chase
9 years, 9 months ago (2011-03-16 02:03:00 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698