DescriptionThis change moves the code I added to git-cl to parse the results of the presubmit hooks into presubmit_support itself. It also removes a lot of the text-file parsing that is no longer necessary since everything is in process.
It also simplifies all of the PresubmitResult* objects and the way we're using output streams since we can assume more about how the callers are calling us.
Note that I uses PEP-8 style method names where I was adding entirely new classes (or rewriting existing classes completely) since per maruel@ he is trying to new that style for new code.
This change also contains two small changes to git_cl to fix bugs and restore the previous behavior of --force skipping the presubmit checks.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78328
Patch Set 1 #
Total comments: 1
Patch Set 2 : backport git-cl fixes from gcl_owners patch #
Messages
Total messages: 5 (0 generated)
|