presubmit_canned_checks.py - Issue 6694009: refactor presubmit parsing code from git-cl into presubmit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 6694009: refactor presubmit parsing code from git-cl into presubmit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: backport git-cl fixes from gcl_owners patch Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index ae6ec97608362c94d33750ce1cd903a6ca114c80..0a78af3c527a96c56992b94fe8579f474ded6f7b 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -648,7 +648,7 @@ def CheckOwners(input_api, output_api, email_regexp=None,

return []

suggested_reviewers = owners_db.reviewers_for(affected_files)

- return [output_api.PresubmitAddText('R=%s' % ','.join(suggested_reviewers))]

+ return [output_api.PresubmitAddReviewers(suggested_reviewers)]

def _Approvers(input_api, email_regexp):

« no previous file with comments | « git_cl/git_cl.py ('k') | presubmit_support.py » ('j') | no next file with comments »