Issue 6693092: Mark CloudPrintURLFetcherOverloadTest.Protect as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6693092: Mark CloudPrintURLFetcherOverloadTest.Protect as flaky. (Closed)

Created:
9 years, 8 months ago by Jeff Timanus

Modified:
9 years, 7 months ago

Reviewers:
Jói

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Mark CloudPrintURLFetcherOverloadTest.Protect as flaky. BUG=78440 TEST=CloudPrintURLFetcherOverloadTest.Protect TBR=joi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80459

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

9 years, 8 months ago (2011-04-05 15:32:56 UTC) #2

LGTM

I'll take the bug.

On Tue, Apr 5, 2011 at 11:21 AM,  <twiz@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Mark CloudPrintURLFetcherOverloadTest.Protect as flaky.
>
> BUG=78440
> TEST=CloudPrintURLFetcherOverloadTest.Protect
> TBR=joi@chromium.org
>
> Please review this at http://codereview.chromium.org/6693092/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>
>
> Index: chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
> ===================================================================
> --- chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  (revision 79553)
> +++ chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  (working copy)
> @@ -310,7 +310,8 @@
>   MessageLoop::current()->Run();
>  }
>
> -TEST_F(CloudPrintURLFetcherOverloadTest, Protect) {
> +// http://code.google.com/p/chromium/issues/detail?id=78440
> +TEST_F(CloudPrintURLFetcherOverloadTest, FLAKY_Protect) {
>   net::TestServer test_server(net::TestServer::TYPE_HTTP,
> FilePath(kDocRoot));
>   ASSERT_TRUE(test_server.Start());
>
>
>
>

Expand Messages | Collapse Messages