Read and Write SSL3, TLS1 and Cert revocation SSL preferences

chrome/browser/ui/webui/options/advanced_options_handler.h

Index: chrome/browser/ui/webui/options/advanced_options_handler.h
===================================================================
--- chrome/browser/ui/webui/options/advanced_options_handler.h	(revision 80372)
+++ chrome/browser/ui/webui/options/advanced_options_handler.h	(working copy)
@@ -66,20 +66,17 @@
   // one item, the font size as a numeric value.
   void HandleDefaultFontSize(const ListValue* args);
 
-#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_FREEBSD) || \
-    defined(OS_OPENBSD)

[wtc, 2011/04/05 18:40:37]

Please understand why this ifdef has OS_WIN but not OS_MACOSX.
You don't need to explain it to me.  I just wanted to make sure
you fully understand this code.

[ramant (doing other things), 2011/04/05 21:01:36]

We used to have special code in advanced_option_handler* for Windows, but not
for Mac. thanks for the keen eye Wan-Teh. 

-  // Callback for the "Check SSL Revocation" checkbox.  This is needed so we
-  // can support manual handling on Windows.
+  // Callback for the "Check SSL Revocation" checkbox. This is called if the
+  // user toggles the "Check SSL Revocation" checkbox.

[wtc, 2011/04/05 18:40:37]

The names of the checkboxes are not exactly right.  They
should be:
  Check for server certificate revocation
  Use SSL 3.0
  Use TLS 1.0

[ramant (doing other things), 2011/04/05 21:01:36]

Done.

   void HandleCheckRevocationCheckbox(const ListValue* args);
 
-  // Callback for the "Use SSL3" checkbox.  This is needed so we can support
-  // manual handling on Windows.
+  // Callback for the "Use SSL3" checkbox. This is called if the user toggles
+  // the "Use SSL3" checkbox.
   void HandleUseSSL3Checkbox(const ListValue* args);
 
-  // Callback for the "Use TLS1" checkbox.  This is needed so we can support
-  // manual handling on Windows.
+  // Callback for the "Use TLS1" checkbox. This is called if the user toggles
+  // the "Use TLS1" checkbox.
   void HandleUseTLS1Checkbox(const ListValue* args);
-#endif
 
 #if !defined(OS_CHROMEOS)
   // Callback for the "showNetworkProxySettings" message. This will invoke
@@ -150,11 +147,8 @@
   // Setup the proxy settings section UI.
   void SetupProxySettingsSection();
 
-#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_FREEBSD) || \
-    defined(OS_OPENBSD)
   // Setup the checked state for SSL related checkboxes.
   void SetupSSLConfigSettings();
-#endif
 
   scoped_refptr<SelectFileDialog> select_folder_dialog_;
 
@@ -166,12 +160,10 @@
   scoped_ptr<CloudPrintSetupHandler> cloud_print_setup_handler_;
 #endif
 
-#if defined(OS_LINUX) || defined(OS_FREEBSD) || defined(OS_OPENBSD)
   // SSLConfigService prefs.
   BooleanPrefMember rev_checking_enabled_;
   BooleanPrefMember ssl3_enabled_;
   BooleanPrefMember tls1_enabled_;
-#endif
 
 #if defined(ENABLE_REMOTING) && !defined(OS_CHROMEOS)
   remoting::RemotingOptionsHandler remoting_options_handler_;