Read and Write SSL3, TLS1 and Cert revocation SSL preferences

chrome/browser/ui/webui/options/advanced_options_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_ADVANCED_OPTIONS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_ADVANCED_OPTIONS_HANDLER_H_
 #pragma once
 
 #include "chrome/browser/prefs/pref_member.h"
 #include "chrome/browser/prefs/pref_set_observer.h"
@@ skipping 48 matching lines @@
 
   // Callback for the "metricsReportingCheckboxAction" message.  This is called
   // if the user toggles the metrics reporting checkbox.
   void HandleMetricsReportingCheckbox(const ListValue* args);
 
   // Callback for the "defaultFontSizeAction" message.  This is called if the
   // user changes the default font size.  |args| is an array that contains
   // one item, the font size as a numeric value.
   void HandleDefaultFontSize(const ListValue* args);
 
-#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_FREEBSD) || \
-    defined(OS_OPENBSD)

[wtc, 2011/04/05 18:40:37]

Please understand why this ifdef has OS_WIN but not OS_MACOSX.
You don't need to explain it to me.  I just wanted to make sure
you fully understand this code.

[ramant (doing other things), 2011/04/05 21:01:36]

We used to have special code in advanced_option_handler* for Windows, but not
for Mac. thanks for the keen eye Wan-Teh. 

-  // Callback for the "Check SSL Revocation" checkbox.  This is needed so we
-  // can support manual handling on Windows.
+  // Callback for the "Check SSL Revocation" checkbox. This is called if the
+  // user toggles the "Check SSL Revocation" checkbox.

[wtc, 2011/04/05 18:40:37]

The names of the checkboxes are not exactly right.  They
should be:
  Check for server certificate revocation
  Use SSL 3.0
  Use TLS 1.0

[ramant (doing other things), 2011/04/05 21:01:36]

Done.

   void HandleCheckRevocationCheckbox(const ListValue* args);
 
-  // Callback for the "Use SSL3" checkbox.  This is needed so we can support
-  // manual handling on Windows.
+  // Callback for the "Use SSL3" checkbox. This is called if the user toggles
+  // the "Use SSL3" checkbox.
   void HandleUseSSL3Checkbox(const ListValue* args);
 
-  // Callback for the "Use TLS1" checkbox.  This is needed so we can support
-  // manual handling on Windows.
+  // Callback for the "Use TLS1" checkbox. This is called if the user toggles
+  // the "Use TLS1" checkbox.
   void HandleUseTLS1Checkbox(const ListValue* args);
-#endif
 
 #if !defined(OS_CHROMEOS)
   // Callback for the "showNetworkProxySettings" message. This will invoke
   // an appropriate dialog for configuring proxy settings.
   void ShowNetworkProxySettings(const ListValue* args);
 #endif
 
 #if !defined(USE_NSS)
   // Callback for the "showManageSSLCertificates" message. This will invoke
   // an appropriate certificate management action based on the platform.
@@ skipping 50 matching lines @@
 
   // Setup the pref whether to prompt for download location every time.
   void SetupPromptForDownload();
 
   // Setup the enabled state of the reset button.
   void SetupAutoOpenFileTypesDisabledAttribute();
 
   // Setup the proxy settings section UI.
   void SetupProxySettingsSection();
 
-#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_FREEBSD) || \
-    defined(OS_OPENBSD)
   // Setup the checked state for SSL related checkboxes.
   void SetupSSLConfigSettings();
-#endif
 
   scoped_refptr<SelectFileDialog> select_folder_dialog_;
 
 #if !defined(OS_CHROMEOS)
   BooleanPrefMember enable_metrics_recording_;
   StringPrefMember cloud_print_proxy_email_;
   BooleanPrefMember cloud_print_proxy_enabled_;
   bool cloud_print_proxy_ui_enabled_;
   scoped_ptr<CloudPrintSetupHandler> cloud_print_setup_handler_;
 #endif
 
-#if defined(OS_LINUX) || defined(OS_FREEBSD) || defined(OS_OPENBSD)
   // SSLConfigService prefs.
   BooleanPrefMember rev_checking_enabled_;
   BooleanPrefMember ssl3_enabled_;
   BooleanPrefMember tls1_enabled_;
-#endif
 
 #if defined(ENABLE_REMOTING) && !defined(OS_CHROMEOS)
   remoting::RemotingOptionsHandler remoting_options_handler_;
 #endif
 
   FilePathPrefMember default_download_location_;
   BooleanPrefMember ask_for_save_location_;
   StringPrefMember auto_open_files_;
   IntegerPrefMember default_font_size_;
   scoped_ptr<PrefSetObserver> proxy_prefs_;
   scoped_ptr<OptionsManagedBannerHandler> banner_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(AdvancedOptionsHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_ADVANCED_OPTIONS_HANDLER_H_