Issue 6691037: wm: Fix an uncommon memory leak in the compositor code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6691037: wm: Fix an uncommon memory leak in the compositor code. (Closed)

Created:
9 years, 8 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
marcheu

CC:
chromium-os-reviews_chromium.org, Greg Spencer (Chromium), Daniel Erat

Base URL:
ssh://gitrw.chromium.org:9222/window_manager.git@master

Visibility:
Public.

wm: Fix an uncommon memory leak in the compositor code. This updates some code to use scoped_ptr. BUG=none TEST=built it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=eafa314

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -35 lines)			Patch
M	compositor/gl/opengl_visitor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compositor/gl/opengl_visitor.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	compositor/gles/opengles_visitor.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	compositor/gles/opengles_visitor.cc	View		5 chunks	+12 lines, -16 lines	0 comments	Download
M	compositor/mock_compositor.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	compositor/mock_compositor.cc	View		3 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Daniel Erat

Just cleaning up some stuff that I noticed while looking at that compositing bug.

9 years, 8 months ago (2011-04-04 17:38:26 UTC) #1

marcheu

9 years, 8 months ago (2011-04-04 17:48:03 UTC) #2

On 2011/04/04 17:38:26, Daniel Erat wrote:
> Just cleaning up some stuff that I noticed while looking at that compositing
> bug.

LGTM.