Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: compositor/gles/opengles_visitor.h

Issue 6691037: wm: Fix an uncommon memory leak in the compositor code. (Closed) Base URL: ssh://gitrw.chromium.org:9222/window_manager.git@master
Patch Set: update another arg to be a const ref Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compositor/gl/opengl_visitor.cc ('k') | compositor/gles/opengles_visitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compositor/gles/opengles_visitor.h
diff --git a/compositor/gles/opengles_visitor.h b/compositor/gles/opengles_visitor.h
index 3fcdd6404fc411fa6fb2f79289e18dc291828be0..378789141779d930dcd75527f7df19c715d81970 100644
--- a/compositor/gles/opengles_visitor.h
+++ b/compositor/gles/opengles_visitor.h
@@ -36,7 +36,7 @@ class OpenGlesDrawVisitor : virtual public RealCompositor::ActorVisitor {
void set_has_fullscreen_actor(bool has_fullscreen_actor) {
has_fullscreen_actor_ = has_fullscreen_actor;
}
- void set_damaged_region(Rect damaged_region) {
+ void set_damaged_region(const Rect& damaged_region) {
damaged_region_ = damaged_region;
}
@@ -68,10 +68,10 @@ class OpenGlesDrawVisitor : virtual public RealCompositor::ActorVisitor {
Compositor::StageActor* stage_; // Not owned.
XConnection* x_connection_; // Not owned.
- TexColorShader* tex_color_shader_;
- TexShadeShader* tex_shade_shader_;
- NoAlphaColorShader* no_alpha_color_shader_;
- NoAlphaShadeShader* no_alpha_shade_shader_;
+ scoped_ptr<TexColorShader> tex_color_shader_;
+ scoped_ptr<TexShadeShader> tex_shade_shader_;
+ scoped_ptr<NoAlphaColorShader> no_alpha_color_shader_;
+ scoped_ptr<NoAlphaShadeShader> no_alpha_shade_shader_;
EGLDisplay egl_display_;
EGLSurface egl_surface_;
« no previous file with comments | « compositor/gl/opengl_visitor.cc ('k') | compositor/gles/opengles_visitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698