Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 6691008: Merge 80842 - 2011-03-11 Anton Muhin <antonm@chromium.org>... (Closed)

Created:
9 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
antonm
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 80842 - 2011-03-11 Anton Muhin <antonm@chromium.org>; Reviewed by Adam Barth. [v8] Change the way group id for CSS objects is calculated https://bugs.webkit.org/show_bug.cgi?id=56117 Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group as they should not be reachable in JavaScript. Covered by existing layout tests. Fact of absence of retention is not trivial to prove. * bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): TBR=antonm@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17661 lines, -12 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +17628 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/V8GCController.cpp View 2 chunks +33 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
antonm
9 years, 9 months ago (2011-03-14 15:32:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698